DNS Engine - Offload DNS to Dedicated Process#1231
Merged
TheTechromancer merged 108 commits intopresetsfrom Apr 26, 2024
Merged
DNS Engine - Offload DNS to Dedicated Process#1231TheTechromancer merged 108 commits intopresetsfrom
TheTechromancer merged 108 commits intopresetsfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## presets #1231 +/- ##
========================================
- Coverage 92% 91% -0%
========================================
Files 316 325 +9
Lines 21213 21611 +398
========================================
+ Hits 19374 19662 +288
- Misses 1839 1949 +110 ☔ View full report in Codecov by Sentry. |
2 tasks
Implement Radix Tree
Faster Regexes
Shared Ansible Dependencies
Intercept Modules
stryker2k2
approved these changes
Apr 26, 2024
Contributor
stryker2k2
left a comment
stryker2k2
left a comment
There was a problem hiding this comment.
Author walked me through this Pull Request. All questions were answered. Code looks good. Test(s) look legit. Realtime BBOT Demo of multi-processor usage was beneficial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an abstract
Enginesystem in BBOT which usespyzmqinROUTER/DEALERmode to farm out resource-intensive tasks to a dedicated process. Pyzmq communicates using binary data over a local unix socket, which is very fast.The DNS Engine is built on top of the abstract
Engineclass, but the same class should be able to be used for HTTP.Original issue: #1223
Speed Benchmark
Command:
dev: 1 minute 57 secondsdns-engine: 1 minute 0 secondsTODO:
Will be merged into #1058.